Update libgit2 binaries to 4ae2905 #461
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 to squash them together. Just a question: Weren't you willing to modify |
|
Updated to squash the libgit2 binary updates into a single update and added a commit to make |
|
@jamill I've manually merged and included the latest libgit2 binaries. ✨✨✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates libgit2 binaries to 4ae2905. There was a failing test that I marked as skip as the underlying issue might take some time to be fully resolved (libgit2/libgit2#1689).
@nulltoken - This commit builds on top of your existing work. Lets consolidate this into a single commit before merging in (take the work under your original commit - that one has most of the work). I can consolidate them myself in whichever way you prefer.