8000 Remove unnecessary finalizers by sharwell · Pull Request #330 · libgit2/libgit2sharp · GitHub
[go: up one dir, main page]
Skip to content

Remove unnecessary finalizers #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove unnecessary finalizers #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbc588b
Remove unnecessary finalizer (cleanup already guaranteed by the SafeH…
sharwell Feb 12, 2013
96542c4
Remove unnecessary finalizer from Repository (cleanup already guarant…
sharwell Feb 12, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions LibGit2Sharp/Core/ObjectSafeWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,5 @@ private void Dispose(bool disposing)
{
objectPtr.SafeDispose();
}

~ObjectSafeWrapper()
{
Dispose(false);
}
}
}
8 changes: 0 additions & 8 deletions LibGit2Sharp/Repository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,6 @@ private void EagerlyLoadTheConfigIfAnyPathHaveBeenPassed(RepositoryOptions optio
}
}

/// <summary>
/// Takes care of releasing all non-managed remaining resources.
/// </summary>
~Repository()
{
Dispose(false);
}

internal RepositorySafeHandle Handle
{
get { return handle; }
Expand Down
0