Fix test analyzer warnings

libgit2 · bording · Mar 16, 2024 · Mar 16, 2024 · Mar 16, 2024 · Mar 16, 2024
commit 9e4669c3d95931acb486cda43fab227217d5e258
diff --git a/LibGit2Sharp.Tests/BranchFixture.cs b/LibGit2Sharp.Tests/BranchFixture.cs
@@ -4,7 +4,6 @@
 using System.Linq;
 using LibGit2Sharp.Tests.TestHelpers;
 using Xunit;
-using Xunit.Extensions;
 
 namespace LibGit2Sharp.Tests
 {
@@ -103,7 +102,7 @@ public void CanCreateAnUnbornBranch()
         public void CanCreateBranchUsingAbbreviatedSha()
         {
             string path = SandboxBareTestRepo();
-            using (var repo = new Repository(path, new RepositoryOptions{ Identity = Constants.Identity }))
+            using (var repo = new Repository(path, new RepositoryOptions { Identity = Constants.Identity }))
             {
                 EnableRefLog(repo);
 
@@ -1001,7 +1000,7 @@ public void OnlyOneBranchIsTheHead()
                         continue;
                     }
 
-                    Assert.True(false, string.Format("Both '{0}' and '{1}' appear to be Head.", head.CanonicalName, branch.CanonicalName));
+                    Assert.Fail(string.Format("Both '{0}' and '{1}' appear to be Head.", head.CanonicalName, branch.CanonicalName));
                 }
 
                 Assert.NotNull(head);

diff --git a/LibGit2Sharp.Tests/FilterFixture.cs b/LibGit2Sharp.Tests/FilterFixture.cs
@@ -1,10 +1,9 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using System.IO;
+using System.Threading.Tasks;
 using LibGit2Sharp.Tests.TestHelpers;
 using Xunit;
-using System.Threading.Tasks;
 
 namespace LibGit2Sharp.Tests
 {
@@ -174,7 +173,7 @@ public void CleanFilterWritesOutputToObjectTree()
         }
 
         [Fact]
-        public void CanHandleMultipleSmudgesConcurrently()
+        public async Task CanHandleMultipleSmudgesConcurrently()
         {
             const string decodedInput = "This is a substitution cipher";
             const string encodedInput = "Guvf vf n fhofgvghgvba pvcure";
@@ -193,20 +192,18 @@ public void CanHandleMultipleSmudgesConcurrently()
 
                 for (int i = 0; i < count; i++)
                 {
-                    tasks[i] = Task.Factory.StartNew(() =>
+                    tasks[i] = Task.Run(() =>
                     {
                         string repoPath = InitNewRepository();
                         return CheckoutFileForSmudge(repoPath, branchName, encodedInput);
                     });
                 }
 
-                Task.WaitAll(tasks);
+                var files = await Task.WhenAll(tasks);
 
-  
10000
              foreach(var task in tasks)
+                foreach (var file in files)
                 {
-                    FileInfo expectedFile = task.Result;
-
-                    string readAllText = File.ReadAllText(expectedFile.FullName);
+                    string readAllText = File.ReadAllText(file.FullName);
                     Assert.Equal(decodedInput, readAllText);
                 }
             }

diff --git a/LibGit2Sharp.Tests/MetaFixture.cs b/LibGit2Sharp.Tests/MetaFixture.cs
@@ -112,7 +112,7 @@ public void TypesInLibGit2DecoratedWithDebuggerDisplayMustFollowTheStandardImplP
 
             if (typesWithDebuggerDisplayAndInvalidImplPattern.Any())
             {
-                Assert.True(false, Environment.NewLine + BuildMissingDebuggerDisplayPropertyMessage(typesWithDebuggerDisplayAndInvalidImplPattern));
+                Assert.Fail(Environment.NewLine + BuildMissingDebuggerDisplayPropertyMessage(typesWithDebuggerDisplayAndInvalidImplPattern));
             }
         }
 
@@ -167,7 +167,7 @@ public void TypesInLibGit2SharpMustBeExtensibleInATestingContext()
 
             if (nonTestableTypes.Any())
             {
-                Assert.True(false, Environment.NewLine + BuildNonTestableTypesMessage(nonTestableTypes));
+                Assert.Fail(Environment.NewLine + BuildNonTestableTypesMessage(nonTestableTypes));
             }
         }
 
@@ -287,7 +287,7 @@ public void GetEnumeratorMethodsInLibGit2SharpMustBeVirtualForTestability()
                         method.DeclaringType, Environment.NewLine);
                 }
 
-                Assert.True(false, Environment.NewLine + sb.ToString());
+                Assert.Fail(Environment.NewLine + sb.ToString());
             }
         }
 
@@ -316,7 +316,7 @@ public void NoPublicTypesUnderLibGit2SharpCoreNamespace()
                         type.FullName, coreNamespace, Environment.NewLine);
                 }
 
-                Assert.True(false, Environment.NewLine + sb.ToString());
+                Assert.Fail(Environment.NewLine + sb.ToString());
             }
         }
 

diff --git a/LibGit2Sharp.Tests/PushFixture.cs b/LibGit2Sharp.Tests/PushFixture.cs
@@ -12,8 +12,7 @@ public class PushFixture : BaseFixture
     {
         private void OnPushStatusError(PushStatusError pushStatusErrors)
         {
-            Assert.True(false, string.Format("Failed to update reference '{0}': {1}",
-                pushStatusErrors.Reference, pushStatusErrors.Message));
+            Assert.Fail(string.Format("Failed to update reference '{0}': {1}", pushStatusErrors.Reference, pushStatusErrors.Message));
         }
 
         private void AssertPush(Action<IRepository> push)

diff --git a/LibGit2Sharp.Tests/TestHelpers/BaseFixture.cs b/LibGit2Sharp.Tests/TestHelpers/BaseFixture.cs
@@ -278,7 +278,7 @@ public virtual void Dispose()
 
             if (Core.LeaksContainer.TypeNames.Any())
             {
-                Assert.False(true, string.Format("Some handles of the following types haven't been properly released: {0}.{1}"
+                Assert.Fail(string.Format("Some handles of the following types haven't been properly released: {0}.{1}"
                     + "In order to get some help fixing those leaks, uncomment the define LEAKS_TRACKING in Libgit2Object.cs{1}"
                     + "and run the tests locally.", string.Join(", ", Core.LeaksContainer.TypeNames), Environment.NewLine));
             }