8000 Updates for trimming compatibility by bording · Pull Request #2084 · libgit2/libgit2sharp · GitHub
[go: up one dir, main page]
Skip to content

Updates for trimming compatibility #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 16, 2024
Merged

Updates for trimming compatibility #2084

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2cad6cd
Add project to test trimming compatibility
bording Mar 14, 2024
70ac848
Address trimming warnings
bording Mar 14, 2024
29b7380
Use .NET 8 SDK
bording Mar 14, 2024
ea4e6c9
Fix failing test
bording Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix failing test
  • Loading branch information
@bording
bording committed Mar 16, 2024
commit ea4e6c979e9fa0c744eca4f42c5dc6bdbfde3dae
2 changes: 1 addition & 1 deletion LibGit2Sharp.Tests/CloneFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ public void CanInspectCertificateOnClone(string url, string hostname, Type certT
Assert.True(valid);
var x509 = ((CertificateX509)cert).Certificate;
// we get a string with the different fields instead of a structure, so...
Assert.Contains("CN=github.com,", x509.Subject);
Assert.Contains("CN=github.com", x509.Subject);
checksHappy = true;
return false;
}
Expand Down
0