LibGit2Sharp: update to libgit2 v1.6.2 #2015
Conversation
|
still haven't figured out what's changed that's affecting #1957 as well. 🙃 |
6a457aa to
892ed37
Compare
I never could figure it out after spending a decent amount of time on it, pretty much bringing any progress here to a halt. |
|
I think the last problem is libgit2/libgit2#6506 |
|
After building with libgit2/libgit2#6506 only one test fails: PR libgit2/libgit2@acb00e4 introduced another builtin extension 'objectformat' which has to be added to the test i think. Once this is done i hope we can get a new release ✌ |
|
@Balkoth to clarify - are you building with this PR and seeing failures around |
|
Oh sorry, i did not use this PR to check, i used what i checked out from the head last week. Obviously this PR fixes the test failures around |
No worries @Balkoth - appreciate the update! |
|
@ethomson any plans on releasing to nuget? |
| /// <summary> | ||
| /// Do not follow any off-site redirects at any stage of | ||
| /// the fetch or push. | ||
| /// </summary> | ||
| None = 0, // GIT_REMOTE_REDIRECT_NONE | ||
|
|
||
| /// <summary> | ||
| /// Allow off-site redirects only upon the initial | ||
| /// request. This is the default. | ||
| /// </summary> | ||
| Auto, // GIT_REMOTE_REDIRECT_INITIAL | ||
|
|
||
| /// <summary> | ||
| /// Allow redirects at any stage in the fetch or push. | ||
| /// </summary> | ||
| All // GIT_REMOTE_REDIRECT_ALL |
There was a problem hiding this comment.
@ethomson I believe this is wrong. According to https://github.com/libgit2/libgit2/blob/2f20fe8869d7a1df7c9b7a9e2939c1a20533c6dc/include/git2/remote.h#L49-L66:
GIT_REMOTE_REDIRECT_NONE = (1 << 0),
GIT_REMOTE_REDIRECT_INITIAL = (1 << 1),
GIT_REMOTE_REDIRECT_ALL = (1 << 2)Which is 1 - 2 - 4 instead of 0 - 1 - 2.
There was a problem hiding this comment.
@bording Also FYI since you're the maintainer.
There was a problem hiding this comment.
Yeah, it seems like that definition should match: #2027
No description provided.