8000 Set / get supported extensions by jairbubbles · Pull Request #1908 · libgit2/libgit2sharp · GitHub
[go: up one dir, main page]
Skip to content

Set / get supported extensions #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 29, 2021
Merged

Set / get supported extensions #1908

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
44a1f22
Set / get supported extensions
jairbubbles Sep 11, 2021
5b92d55
Add params keyword
jairbubbles Sep 12, 2021
7f21164
Use GitStrArray
jairbubbles Nov 22, 2021
5a515d7
Attempt to fix memory corruption
jairbubbles Nov 22, 2021
0a2e640
Cosmetic
jairbubbles Nov 22, 2021
3c4473c
Update test
jairbubbles Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use GitStrArray
  • Loading branch information
@jairbubbles
jairbubbles committed Nov 22, 2021
commit 7f21164d569986fdf1fb198c7162b67cc9e7c491
2 changes: 1 addition & 1 deletion LibGit2Sharp/Core/NativeMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,7 @@ internal static extern int git_libgit2_opts(int option,

// git_libgit2_opts(GIT_OPT_SET_EXTENSIONS, const char **extensions, size_t len)
[DllImport(libgit2, CallingConvention = CallingConvention.Cdecl)]
internal static extern int git_libgit2_opts(int option, string[] extensions, int len);
internal static extern int git_libgit2_opts(int option, GitStrArray extensions);

// git_libgit2_opts(GIT_OPT_GET_EXTENSIONS, git_strarray *out)
[DllImport(libgit2, CallingConvention = CallingConvention.Cdecl)]
Expand Down
7 changes: 5 additions & 2 deletions LibGit2Sharp/Core/Proxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3503,8 +3503,11 @@ public static string git_libgit2_opts_get_user_agent()

public static void git_libgit2_opts_set_extensions(string[] extensions)
{
var res = NativeMethods.git_libgit2_opts((int)LibGit2Option.SetExtensions, extensions, extensions.Length);
Ensure.ZeroResult(res);
using(var array = GitStrArrayManaged.BuildFrom(extensions))
{
var res = NativeMethods.git_libgit2_opts((int)LibGit2Option.SetExtensions, array.Array);
Ensure.ZeroResult(res);
}
}

public static string[] git_libgit2_opts_get_extensions()
Expand Down
0