8000 Update to libgit2 v1.2.0 by jairbubbles · Pull Request #1907 · libgit2/libgit2sharp · GitHub
[go: up one dir, main page]
Skip to content

Update to libgit2 v1.2.0 #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 16, 2021
Merged

Update to libgit2 v1.2.0 #1907

merged 4 commits into from
Sep 16, 2021

Conversation

jairbubbles
Copy link
Contributor
@jairbubbles jairbubbles commented Sep 5, 2021 •
edited
Loading

@jairbubbles
Copy link
Contributor Author

Hey @bording @A-Ovchinnikov-mx, I started to look at integrating the new versions but many tests are failing 😅

Some tests like LibGit2Sharp.Tests.RebaseFixture.CanContinueRebase do generate a System.AccessViolationException which is a bit worrying (cc @ethomson)

I started to look at the is_valid_name depreciation but because of libgit2/libgit2#6032 we cannot switch yet to the new version.

@jairbubbles
Copy link
Contributor Author
jairbubbles commented Sep 5, 2021 •
edited
Loading

Ok, thanks to libgit2/git2go#777 I found the culprit for the memory corruption. A new callback create_commit_cb was added (libgit2/libgit2#6016) but it's not at the end of the struct.

EDIT: same problem with the introduction of git_remote_ready_cb (see libgit2/libgit2#6012)
EDIT2: The introcution of writemidx also corrupted the layout (see libgit2/libgit2#5405)

@codecov-commenter
Copy link
codecov-commenter commented Sep 5, 2021 •
edited
Loading

Codecov Report

Merging #1907 (491d248) into master (6329bea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1907   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files         231      231           
  Lines        9120     9120           
=======================================
  Hits         7734     7734           
  Misses       1386     1386
Impacted Files Coverage Δ
LibGit2Sharp/Core/GitOdbBackend.cs 100.00% <ø> (ø)
LibGit2Sharp/Core/GitRebaseOptions.cs 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6329bea...491d248. Read the comment docs.

@jairbubbles jairbubbles marked this pull request as ready for review September 5, 2021 08:15
@extrawurst extrawurst mentioned this pull request Sep 5, 2021
Closed
@bording
Copy link
Member
bording commented Sep 16, 2021

At some point I guess we'll need to turn those padding fields into actual things, but for now I'll just go ahead and merge this.

@bording bording merged commit 5055fbd into libgit2:master Sep 16, 2021
@bording
Copy link
Member
bording commented Sep 16, 2021

Before I push up a new preview package that uses this, I need to rip out all of the managed HTTPS implementation stuff added in #1618 and go back to using the native OpenSSL stuff. I should have some time this weekend to take a look at that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bording bording bording approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jairbubbles @codecov-commenter @bording
0