8000 Avoid reading and writing global state when loading native library by tmat · Pull Request #1563 · libgit2/libgit2sharp · GitHub
[go: up one dir, main page]
Skip to content

Avoid reading and writing global state when loading native library #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 17, 2018
Merged

Avoid reading and writing global state when loading native library #1563

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b01c549
Avoid reading and writing global state when loading native library
tmat Apr 11, 2018
0e2665c
Add test.
tmat Apr 12, 2018
8a10035
Make test types internal
tmat Apr 12, 2018
748e596
PR feedback and test both x64 and x86 platforms
tmat Apr 12, 2018
671d058
Rename platform to architecture
tmat Apr 12, 2018
2c1e96d
Do not create packages for test app projects
tmat Apr 14, 2018
fc7b5b3
Search for native library in runtimes dir and allow setting NativeLib…
tmat Apr 14, 2018
fe71caa
Avoid IVT
tmat Apr 16, 2018
9aadf0b
Generate NativeDllName in tests
tmat Apr 16, 2018
896eb24
Rename TestApp to NativeLibraryLoadTestApp
tmat Apr 16, 2018
53e1fea
Fix path
tmat Apr 16, 2018
e618156
Do not set default value for NativeLibararyPath on .NET Core
tmat Apr 16, 2018
d9496ba
Clean up trailing whitespace
bording Apr 17, 2018
497f91f
Add code generation targets to Solution Items
bording Apr 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make test types internal
  • Loading branch information
@tmat
tmat committed Apr 16, 2018
commit 8a10035c2cbd5ad635386c8675c2489f624f882d
< 8000 button type="button" class="btn-link color-fg-muted no-underline js-expand-full directional-expander tooltipped tooltipped-se" aria-label="Expand all" data-url="/libgit2/libgit2sharp/blob_expand/cc052a4b8040ee4cb3273f75942e437f87b05ecc?anchor=diff-ffdac36756bdc5e3895611f6e8c738f2355653dac78108d44a224d398b364326&context=pull_request&diff=unified&direction=full&mode=100644&path=LibGit2Sharp.Tests%2FTestHelpers%2FConditionalFactAttribute.cs&pull_request_id=181066406" >
6 changes: 3 additions & 3 deletions LibGit2Sharp.Tests/TestHelpers/ConditionalFactAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

namespace LibGit2Sharp.Tests
{
public class ConditionalFactAttribute : FactAttribute
internal class ConditionalFactAttribute : FactAttribute
{
public ConditionalFactAttribute(params Type[] skipConditions)
{
Expand All @@ -22,13 +22,13 @@ public ConditionalFactAttribute(params Type[] skipConditions)
}
}

public abstract class ExecutionCondition
internal abstract class ExecutionCondition
{
public abstract bool ShouldSkip { get; }
public abstract string SkipReason { get; }
}

public class NetFramework : ExecutionCondition
internal class NetFramework : ExecutionCondition
{
public override bool ShouldSkip => !Platform.IsRunningOnNetFramework();
public override string SkipReason => ".NET Framework only test";
Expand Down
0