Update libgit2 natives to 1.0.160 #1349
Conversation
|
How did I miss this... Looks, good, are you planning on exposing the new APIs in a different commit? |
| @@ -989,7 +976,7 @@ static NativeMethods() | |||
|
|
|||
| /* Push network progress notification function */ | |||
| internal delegate int git_push_transfer_progress(uint current, uint total, UIntPtr bytes, IntPtr payload); | |||
| internal delegate int git_packbuilder_progress(int stage, uint current, uint total, IntPtr payload); | |||
| internal delegate int git_packbuilder_progress(int stage, UInt32 current, UInt32 total, IntPtr payload); | |||
There was a problem hiding this comment.
Is this really needed? uint is always a synonym for System.UInt32
There was a problem hiding this comment.
Right, probably not. Thanks!
I don't have any plans to. Is there something in particular that you're interested in? Is that something that you'd want to tackle? |
|
Yeah, I would like to tackle it(exposnig all the new APIs) beginning with (Set|Get)UserAgent . Actually, I already started doing that, but I ran against #1339 and kind of lost track... |
|
Unless we've deprecated something, in which case we should immediately provide the new way of doing it, I'd rather not conflate the binaries update with exposing new functionality. |
| @@ -1,4 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <packages> | |||
| <package id="LibGit2Sharp.NativeBinaries" version="1.0.157" targetFramework="net4" allowedVersions="[1.0.157]" /> | |||
| <package id="LibGit2Sharp.NativeBinaries" version="1.0.160" targetFramework="net40" /> | |||
There was a problem hiding this comment.
I think this should still have a allowedVersions to stop it from trying to "update" to an incompatible version of the binaries.
11381d5 to
88cf9a7
Compare
Update libgit2 to native version 1.0.160 (libgit2/libgit2@baa87df).