Fix C4703 uninitialized pointer variable warnings #7154
+17
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huskydawg
approved these changes
Oct 28, 2025
tyrielv
reviewed
Oct 29, 2025
src/util/net.c
Outdated
| const char *authority, | ||
| size_t len) | ||
| { | ||
| const char *c, *hostport_end, *host_end = NULL, |
Contributor
There was a problem hiding this comment.
Why do only some of these need an individual = NULL and not others? You've added one for userpass_end but c and hostport_end still don't have one.
Author
There was a problem hiding this comment.
It's up to the compiler to look at usage after this and whether or not it will get deterministically assigned versus for others. I can get these as well just for consistency versus only fixing ones that /SDL asked for given the usage afterwards.
tyrielv
reviewed
Oct 29, 2025
src/util/net.c
Outdated
| { | ||
| git_net_url_parser parser = GIT_NET_URL_PARSER_INIT; | ||
| const char *c, *authority, *path = NULL; | ||
| const char *c, *authority = NULL, *path = NULL; |
Contributor
There was a problem hiding this comment.
Similar, why does authority need it but not c?
tyrielv
approved these changes
Oct 29, 2025
Contributor
There was a problem hiding this comment.
I suspect more warnings will pop up since there are still uninitialized variables, but what's there is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses C4703 uninitialized variables warnings that promote to errors with /sdl flag
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4703?view=msvc-170