refs: honor REFSPEC_SHORTHAND for multi-segment refs #7148
+54
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GIT_REFERENCE_FORMAT_REFSPEC_SHORTHAND is documented to "interpret the name as part of a refspec in shorthand form so the ONELEVEL naming rules aren't enforced and 'master' becomes a valid name." However, the multi-segment pseudoref check was not respecting this flag, rejecting valid refspecs like "A/b" and "HEAD/feature" even when SHORTHAND was set. The single-segment check at line 1015 already honors this flag. This change makes the multi-segment check at line 1021 consistent with that behavior and with the documented intent. Git itself accepts these refspec patterns without issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GIT_REFERENCE_FORMAT_REFSPEC_SHORTHANDis documented to "interpret the name as part of a refspec in shorthand form so the ONELEVEL naming rules aren't enforced and 'master' becomes a valid name."However, the multi-segment pseudoref check was not respecting this flag, rejecting valid refspecs like
"A/b"and"HEAD/feature"even when SHORTHAND was set.The single-segment check at line 1015 already honors this flag. This change makes the multi-segment check at line 1021 consistent with that behavior and with the documented intent.
Git itself accepts these refspec patterns without issue.
In Nix we've applied a workaround instead (NixOS/nix#14253) but this still seems to be a problem in libgit2.