8000 No `.git` for separate workdir by ethomson · Pull Request #6982 · libgit2/libgit2 · GitHub
[go: up one dir, main page]
Skip to content

No .git for separate workdir #6982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2024
Merged

No .git for separate workdir #6982

merged 1 commit into from
Dec 30, 2024

Conversation

ethomson
Copy link
Member
@ethomson ethomson commented Dec 27, 2024 •
edited
Loading

When specifying a separate working directory path, the given repository path should never have a .git directory created beneath it. That simply doesn't make sense.

@ethomson ethomson force-pushed the ethomson/no_dotgit_for_separate_workdir branch 2 times, most recently from 5ea0ba5 to f1a6d00 Compare December 27, 2024 16:40
@ethomson
Copy link
Member Author

This is a behavioral breaking change - it removes the ability for users to specify GIT_REPOSITORY_INIT_NO_DOTGIT_DIR and not specify a separate working directory. That... doesn't make any sense.

@ethomson ethomson mentioned this pull request Dec 27, 2024
Merged
@ethomson ethomson force-pushed the ethomson/no_dotgit_for_separate_workdir branch from f1a6d00 to cba7cd0 Compare December 28, 2024 23:51
@ethomson
repo: workdir_path implies no dotgit in init
ca2a241 
When specifying a separate working directory path, the given repository
path should never have a `.git` directory created beneath it. That
simply doesn't make sense.

As a result, the `GIT_REPOSITORY_INIT_NO_DOTGIT_DIR` now _also_ no
longer makes sense. It would only ever be a sensible option when one
wanted a separate `.git` directory and working directory, otherwise the
git files and working directory files would be comingled. Remove the
option entirely.
@ethomson ethomson force-pushed the ethomson/no_dotgit_for_separate_workdir branch from cba7cd0 to ca2a241 Compare December 30, 2024 20:37
@ethomson ethomson merged commit 9961198 into main Dec 30, 2024
19 checks passed
@ethomson ethomson deleted the ethomson/no_dotgit_for_separate_workdir branch December 30, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ethomson
0