8000 SHA256 improvements by ethomson · Pull Request #6965 · libgit2/libgit2 · GitHub
[go: up one dir, main page]
Skip to content

SHA256 improvements #6965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 18, 2024
Merged

SHA256 improvements #6965

merged 9 commits into from
Dec 18, 2024

Conversation

ethomson
Copy link
Member

A handful of improvements to the SHA256 support - especially future-proofing the options structures.

@ethomson
oid: provide private type_is_valid functionality
009677e 
As users begin to specify the object ID types, provide an internal
mechanism to determine whether the type is valid / supported or not.
@ethomson
index: provide a index_options structure when opening
708d64f 
Instead of simply taking the oid type, future-proof our index opening
and creation functionality by taking an options structure.
@ethomson
indexer: move oid_type into the opts structure
9aa5faa 
Object ID type should be an option within the options structure; move it
there.
@ethomson
repo: specify odb options to odb_wrap
cefcabf 
odb wrapping
@ethomson
repo: don't require oid_type to wrap_odb
43c31ec 
The `wrap_odb` function doesn't need to know the OID types in the object
database; the object database already knows the type.
@ethomson
repo: take an options structure for repository_new
622035e 
Future-proof the SHA256-ification of `git_repository_new` by taking an
options structure instead of an oid type.
@ethomson
commit_graph: move opts to new function
54d666e 
Instead of making the commit and dump functions take individual options
structures; provide the options structure to the writer creator. This
allows us to add additional information (like OID type) during
generation.
@ethomson
commit_graph: add opts to open function
0738b05 
Provide an options structure to commit graph opening. This allows us to
specify information (like OID type) during opening.
@ethomson
midx: add options to writer function
6aa9bc4 
Provide an options structure to MIDX writing. This allows us to
specify information (like OID type) during writer creation.
@ethomson ethomson merged commit 4dcdb64 into 755E main Dec 18, 2024
38 checks passed
@ethomson ethomson deleted the ethomson/sha256 branch December 18, 2024 22:46
@BrewTestBot BrewTestBot mentioned this pull request Dec 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sys api breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ethomson
0