8000 remote: Handle fetching negative refspecs by ryan-ph · Pull Request #6962 · libgit2/libgit2 · GitHub
[go: up one dir, main page]
Skip to content

remote: Handle fetching negative refspecs #6962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 24, 2024
Merged

remote: Handle fetching negative refspecs #6962

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3d9f406
refspec: Add func to distinguish negative refspecs
ryan-ph Nov 28, 2024
f7f30ec
remote: Handle fetching negative refspecs
ryan-ph Nov 28, 2024
83994da
remote: Remove unnecessary call
ryan-ph Dec 24, 2024
6039d28
remote: Return first matching refspec
ryan-ph Dec 24, 2024
099e62c
remote: Don't use designated initializer
ryan-ph Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
8000
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remote: Remove unnecessary call 
`git_refspec_is_negative()` is already called by
`git_refspec_src_matches_negative()`, so should not be necessary here.
  • Loading branch information
@ryan-ph
ryan-ph committed Dec 24, 2024
commit 83994dafec424346b9f5752fd7a44bd95b9598cd
2 changes: 1 addition & 1 deletion src/libgit2/remote.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2635,7 +2635,7 @@ git_refspec *git_remote__matching_refspec(git_remote *remote, const char *refnam
if (spec->push)
continue;

if (git_refspec_is_negative(spec) && git_refspec_src_matches_negative(spec, refname))
if (git_refspec_src_matches_negative(spec, refname))
return NULL;

if (git_refspec_src_matches(spec, refname))
Expand Down
0