schannel: Fix certificate error reporting and ignore some trust errors by default #6941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OFFLINE_REVOCATION, just as Git for Windows does.
|
Test fails (not when I run it locally though), meaning the CI environment must be different. Might be a tricky one to test... |
|
I think that you're testing the literal error messages that come out of schannel and the Linux and Mac implementations are slightly different messages. |
lrm29
commented
Dec 11, 2024
tests/libgit2/online/badssl.c
Outdated
| git_clone( | ||
| &g_repo, "https://untrusted-root.badssl.com/fake.git", | ||
| "./fake", NULL)); | ||
| cl_assert_equal_i(git_error_last()->klass, GIT_ERROR_SSL); |
There was a problem hiding this comment.
With WinHTTP this error code would be GIT_ERROR_HTTP, and as pointed out the message strings are very different with all the other implementations (I should do this stuff in the morning...).
This test is a bit pointless I suppose as it's just testing error message concatenation. What I really want to test is this logic that I added, but I'm not sure how:
if ((st->cert_chain->TrustStatus.dwErrorStatus &
~(DWORD)(CERT_TRUST_REVOCATION_STATUS_UNKNOWN |
CERT_TRUST_IS_OFFLINE_REVOCATION)) != CERT_TRUST_NO_ERROR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #6724.
I would add support for querying "http.schannelcheckrevoke", but am not sure how to get a repository config snapshot in this function. Or could just get the global config. I didn't see any stream implementations that query the config.