Merged
Conversation
966e4f3 to
dfc4d4b
Compare
|
Any progress on this PR? This's really helpful to someone who wants to get libgit2 easily used in a CMake based project. |
Contributor
Author
The task is ready, but needs to be accepted |
Closed
ethomson
reviewed
Dec 23, 2024
src/cli/CMakeLists.txt
Outdated
| endif() | ||
|
|
||
| install(TARGETS git2_cli RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}) | ||
| install(TARGETS git2_cli EXPORT ${LIBGIT2_TARGETS_EXPORT_NAME} RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}) |
Member
There was a problem hiding this comment.
Curious why we'd export the CLI targets? How would somebody make use of this and why would they want it? 🤔
Contributor
Author
There was a problem hiding this comment.
You are correct, for the git cli, the export is unnecessary.
Member
|
Thanks for your patience. Every time I look at cmake, my eyes glaze over, and I need to go lie down. Just one question to start with about the CLI. |
Member
|
Thanks for the fix! This will land in v1.9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes will let the user call the command
find_package(libgit2)when the library is installed, this can be use as aguarantee that the package is properly installed.