8000 Fix some bugs caught by UBscan by ethomson · Pull Request #6700 · libgit2/libgit2 · GitHub
[go: up one dir, main page]
Skip to content

Fix some bugs caught by UBscan #6700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Fix some bugs caught by UBscan #6700

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
032a8c2
util: our strcmp cb should use git__strcmp
ethomson Dec 20, 2023
6816f30
Use the correct function definition for function pointers
ethomson Dec 20, 2023
01d2adc
remote: pass the commit not its id in tests
ethomson Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
util: our strcmp cb should use git__strcmp
  • Loading branch information
@ethomson
ethomson committed Dec 20, 2023
commit 032a8c2d5c75a3c23888a7e809e536636dfd54d5
4 changes: 2 additions & 2 deletions src/util/util.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,12 +623,12 @@ int git__bsearch_r(
*/
int git__strcmp_cb(const void *a, const void *b)
{
return strcmp((const char *)a, (const char *)b);
return git__strcmp((const char *)a, (const char *)b);
}

int git__strcasecmp_cb(const void *a, const void *b)
{
return strcasecmp((const char *)a, (const char *)b);
return git__strcasecmp((const char *)a, (const char *)b);
}

int git__parse_bool(int *out, const char *value)
Expand Down
0