8000 cmake: rename FindIconv to avoid collision with cmake by ethomson · Pull Request #6682 · libgit2/libgit2 · GitHub
[go: up one dir, main page]
Skip to content

cmake: rename FindIconv to avoid collision with cmake #6682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2023
Merged

cmake: rename FindIconv to avoid collision with cmake #6682

merged 1 commit into from
Dec 16, 2023

Conversation

ethomson
Copy link
Member

cmake now includes FindIconv. Rename ours to avoid any confusion.

Fixes #6644

@ethomson
cmake: rename FindIconv to avoid collision with cmake
9d767b9 
cmake now includes `FindIconv`. Rename ours to avoid any confusion.
@ethomson ethomson merged commit 955b297 into main Dec 16, 2023
@ethomson ethomson deleted the ethomson/find_iconv branch December 16, 2023 14:04
@ethomson ethomson added the build label Feb 18, 2024
@branchvincent branchvincent mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ld: Undefined symbols: _libiconv _libiconv_close _libiconv_open
1 participant
@ethomson
0