10000 add dl to LIBGIT2_SYSTEM_LIBS by christopherfujino · Pull Request #6631 · libgit2/libgit2 · GitHub
[go: up one dir, main page]
Skip to content

add dl to LIBGIT2_SYSTEM_LIBS #6631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2024
Merged

add dl to LIBGIT2_SYSTEM_LIBS #6631

merged 3 commits into from
Feb 17, 2024

Conversation

christopherfujino
Copy link
Contributor
@christopherfujino christopherfujino commented Sep 10, 2023 •
edited
Loading

Fixes #6632

Arguably the real issue here is that the FindOpenSSL.cmake module should have included this in the OPENSSL_CRYPTO_LIBRARIES variable: https://github.com/Kitware/CMake/blob/master/Modules/FindOpenSSL.cmake#L544

@christopherfujino christopherfujino mentioned this pull request Sep 10, 2023
Closed
@christopherfujino christopherfujino marked this pull request as ready for review September 10, 2023 03:25
@ethomson
Copy link
Member

Thanks for the fix!

@ethomson ethomson merged commit bfe0ac7 into libgit2:main Feb 17, 2024
@ethomson ethomson added the build label Feb 18, 2024
@branchvincent branchvincent mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethomson ethomson ethomson approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

statically linking libgit2 results in linker error with openssl not being linked to -ldl
2 participants
@christopherfujino @ethomson
0