8000 Make failure to connect to ssh-agent non-fatal by fxcoudert · Pull Request #6497 · libgit2/libgit2 · GitHub
[go: up one dir, main page]
Skip to content

Make failure to connect to ssh-agent non-fatal #6497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Make failure to connect to ssh-agent non-fatal #6497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make failure to connect to ssh-agent non-fatal 
Fixes #3866

Has been applied in all Julia builds since 2017:
JuliaLang/julia#17459

Authored-by: Keno Fischer <kfischer@college.harvard.edu>
  • Loading branch information
@fxcoudert
fxcoudert committed Feb 22, 2023
commit d286952f9e8fce847404f2651e4e341dd33e96eb
4 changes: 3 additions & 1 deletion src/libgit2/transports/ssh.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,10 @@ static int ssh_agent_auth(LIBSSH2_SESSION *session, git_credential_ssh_key *c) {

rc = libssh2_agent_connect(agent);

if (rc != LIBSSH2_ERROR_NONE)
if (rc != LIBSSH2_ERROR_NONE) {
rc = LIBSSH2_ERROR_AUTHENTICATION_FAILED;
goto shutdown;
}

rc = libssh2_agent_list_identities(agent);

Expand Down
0