8000 refdb_fs: initialize backend version by pks-t · Pull Request #5456 · libgit2/libgit2 · GitHub
[go: up one dir, main page]
Skip to content

refdb_fs: initialize backend version #5456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2020
Merged

refdb_fs: initialize backend version #5456

merged 1 commit into from
Mar 23, 2020

Conversation

pks-t
Copy link
Member
@pks-t pks-t commented Mar 13, 2020

While the git_refdb_backend() struct has a version, we do not
initialize it correctly when calling git_refdb_backend_fs(). Fix this
by adding the call to git_refdb_init_backend().

@pks-t
Copy link
Member Author
pks-t commented Mar 13, 2020

Fixes #5449

@pks-t pks-t mentioned this pull request Mar 13, 2020
Closed
@pks-t pks-t force-pushed the pks/refdb-fs-backend-version branch from e56d2c1 to 6526929 Compare March 13, 2020 22:08
@ddevault ddevault mentioned this pull request Mar 19, 2020
Merged
7 tasks
@pks-t
refdb_fs: initialize backend version
a2d3316 
While the `git_refdb_backend()` struct has a version, we do not
initialize it correctly when calling `git_refdb_backend_fs()`. Fix this
by adding the call to `git_refdb_init_backend()`.
@pks-t pks-t force-pushed the pks/refdb-fs-backend-version branch from 6526929 to a2d3316 Compare March 22, 2020 15:23
@pks-t pks-t added the 1.0 label Mar 22, 2020
ethomson
ethomson approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member
@ethomson ethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we can take this for 1.0. 😬

@ethomson ethomson merged commit dd43571 into libgit2:master Mar 23, 2020
@pks-t pks-t deleted the pks/refdb-fs-backend-version branch March 23, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethomson ethomson ethomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pks-t @ethomson
0