8000 CMake: minor fixups by ethomson · Pull Request #4513 · libgit2/libgit2 · GitHub
[go: up one dir, main page]
Skip to content

CMake: minor fixups #4513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 7, 2018
Merged

CMake: minor fixups #4513

merged 5 commits into from
Feb 7, 2018

Conversation

ethomson
Copy link
Member
@ethomson ethomson commented Feb 3, 2018

Some minor fixups and refactoring for CMake:

  1. Move the CMP0051 policy check to use the policy check functionality instead of guessing based on version number.
  2. Enable the CMP0042 policy, for macOS; this has no functional change, but it quiets a warning about how it's being applied.
  3. Move some things out of the CMakeList.txt into modules.

@ethomson
cmake: test for CMP0051 instead of version check
8000
94aa36e 
We can use policy checks to see if a policy exists in cmake, like
CMP0051, instead of relying on the version.
@ethomson
cmake: enable policy CMP0042
6416b91 
Enable CMake policy CMP0042, if supported:

> CMake 2.8.12 and newer has support for using ``@rpath`` in a target's
> install name.  This was enabled by setting the target property
> ``MACOSX_RPATH``.  The ``@rpath`` in an install name is a more
> flexible and powerful mechanism than ``@executable_path`` or
> ``@loader_path`` for locating shared libraries.
@ethomson
cmake: move nanosecond detection to a module
ed298c8 
Move the nanosecond detection in time structures to its own module.
@ethomson
cmake: Move IDE source munging to a module
fc6e38c 
Move the odd code that provides a hierarchical display for projects
within the IDEs to its own module.
This was referenced Feb 3, 2018
Closed
Closed
@pks-t
Copy link
Member
pks-t commented Feb 5, 2018

Thanks, these definitly help to make our build instructions easier to read. I think 412e91b is missing a piece, you don't ever include that new module.

@ethomson ethomson force-pushed the ethomson/cmake_fixes branch from 412e91b to f8a2dda Compare February 5, 2018 17:17
@ethomson
Copy link
Member Author
ethomson commented Feb 7, 2018

Thanks, these definitly help to make our build instructions easier to read. I think 412e91b is missing a piece, you don't ever include that new module.

It was missing that, thanks @pks-t .

@ethomson ethomson merged commit f722594 into master Feb 7, 2018
@ethomson ethomson deleted the ethomson/cmake_fixes branch October 26, 2018 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IDisposable IDisposable IDisposable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethomson @pks-t @IDisposable
3190
0