Conversation
We can use policy checks to see if a policy exists in cmake, like CMP0051, instead of relying on the version.
Enable CMake policy CMP0042, if supported: > CMake 2.8.12 and newer has support for using ``@rpath`` in a target's > install name. This was enabled by setting the target property > ``MACOSX_RPATH``. The ``@rpath`` in an install name is a more > flexible and powerful mechanism than ``@executable_path`` or > ``@loader_path`` for locating shared libraries.
Move the nanosecond detection in time structures to its own module.
Move the odd code that provides a hierarchical display for projects within the IDEs to its own module.
This was referenced Feb 3, 2018
Member
|
Thanks, these definitly help to make our build instructions easier to read. I think 412e91b is missing a piece, you don't ever include that new module. |
412e91b to
f8a2dda
Compare
IDisposable
approved these changes
Feb 7, 2018
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor fixups and refactoring for CMake:
CMP0051policy check to use the policy check functionality instead of guessing based on version number.CMP0042policy, for macOS; this has no functional change, but it quiets a warning about how it's being applied.CMakeList.txtinto modules.