-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Streaming filters #2911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Streaming filters #2911
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fbdc9db
filters: introduce streaming filters
5555696
filters: stream internally
e78f5c9
checkout: stream the blob into the filters
646364e
checkout: maintain temporary buffer for filters
ethomson 8c2dfb3
filter: test a large file through the stream
b75f15a
git_writestream: from git_filter_stream
f7c0125
filter streams: base -> parent
b49eddd
checkout: let the stream writer close the fd
d4cf167
buffer: introduce git_buf_attach_notowned
795eacc
git_filter_opt_t -> git_filter_flag_t
d05218b
filter: add `git_filter_list__load_ext`
9c9aa1b
filter: take `temp_buf` in `git_filter_options`
feb0e02
tests: separate INVASIVE filesystem tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
checkout: maintain temporary buffer for filters
Let the filters use the checkout data's temporary buffer, instead of having to allocate new buffers each time.
- Loading branch information
commit 646364e780c65b1af2e28a7bdeabd22b67816454
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
if
looks odd. Can we not have the filter list here? We seem to assume later on that we do have it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can not - the existing filters system let you pass a
NULL
filter_list
to simply skip the filtering. (https://github.com/libgit2/libgit2/blob/master/src/filter.c#L631) This maintains that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, I hadn't noticed that we always use functions around
fl
and do check if it'sNULL
each time.