8000 Merge push in remote by tiennou · Pull Request #2516 · libgit2/libgit2 · GitHub
[go: up one dir, main page]
Skip to content

Merge push in remote #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Merge push in remote #2516

wants to merge 9 commits into from

Conversation

tiennou
Copy link
Contributor
@tiennou tiennou commented Aug 13, 2014

A rebased #2221, because it was based on development.

@tiennou
Copy link
Contributor Author
tiennou commented Aug 13, 2014

Travis still hates me 😢. I'm suspecting state is being shared in those tests, like b1 gets pushed, the test pass, then you push b2 and the test finds both b1 and b2 and thus fails. I'm pretty sure the other pack_progress_calls > 0 are the same kind : since it's already up to date, it doesn't get called... If someone has a clue ;-).

@tiennou tiennou mentioned this pull request Aug 14, 2014
Merged
@carlosmn
Copy link
Member

Yes, the push tests do leave some state behind. IIRC most of the push tests make sure initially that they clean up whatever is in the repository.

@carlosmn
Copy link
Member

Superseded by #2608 . The push state was definitely quite fiddly.

@carlosmn carlosmn closed this Nov 18, 2014
@tiennou tiennou deleted the merge-push-in-remote branch August 1, 2017 18:45
@tiennou tiennou mentioned this pull request Aug 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiennou @carlosmn
0