10BC0 Draft archive_read_data_into_FILE by vadimkantorov · Pull Request #2504 · libarchive/libarchive · GitHub
[go: up one dir, main page]
Skip to content

Draft archive_read_data_into_FILE #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Draft archive_read_data_into_FILE #2504

wants to merge 7 commits into from

Conversation

vadimkantorov
Copy link
@vadimkantorov vadimkantorov commented Feb 6, 2025 •
edited
Loading

WIP for #2299

  • still no tests, docs
  • for now put the archive_read_data_into_FILE function in libarchive/archive_read_data_into_fd.c - to be moved into a new file
  • no integration in the build system
  • checks for now fail because this new function is unused and does not have prototype in the public API

Questions:

  • Should use fseeko instead of fseek? If not, how to handle seek offset not fitting into long?
  • Is the approach of trying seeking and then falling back to writing nulls okay?
    • For the archive_read_data_into_fd libarchive uses fstat to do the test, but for working with FILE stat might not be available, or fileno might not be supported (e.g. for fmemopen or open_memstream-produced FILE - this is my original usecase)
    • Should I instead still try retrieving fileno and if it's >= do the stat?
  • Can't we just allocate 16384 bytes on stack (and memzero them) instead of using the allocator/ calloc/free? Or even always have a zero-valued static byte array? (the same question for existing archive_read_data_into_fd)

Thanks!

@vadimkantorov vadimkantorov mentioned this pull request Feb 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vadimkantorov
0