10000 feat(publish): replace +{SHA} with .{SHA} in lerna publish --canary by MatusKnizka · Pull Request #4124 · lerna/lerna · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(publish): replace +{SHA} with .{SHA} in lerna publish --canary #4124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(publish): replace +{SHA} with .{SHA} in lerna publish --canary #4124

wants to merge 2 commits into from

Conversation

MatusKnizka
Copy link
@MatusKnizka MatusKnizka commented Nov 15, 2024 •
edited
Loading

Replace +{SHA} with .{SHA} in lerna publish --canary

Description

Instead of using plus (+) sign in package name provided by --canary flag, use dot.

Motivation and Context

It's not possible to publish --canary version into jfrog artifactory, as jfrog is cutting part of filename, due to + (plus) character. So, instead of using +, I would suggest to use dot.

#2060

How Has This Been Tested?

Unit tests
Integration tests
Run publish command

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ghiscoding ghiscoding mentioned this pull request Dec 11, 2024
Open
@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Feb 19, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 64ae261.

Command Status Duration Result
nx run-many --t e2e --parallel=1 ✅ Succeeded 3m 59s View ↗
nx run integration:integration --ci --maxWorkers=2 ✅ Succeeded 3m 22s View ↗
nx run-many -t test --parallel=3 --ci --maxWork... ✅ Succeeded 44s View ↗
nx run-many -t lint --parallel=3 ✅ Succeeded 18s View ↗
nx run-many -t build --parallel=3 ✅ Succeeded 12s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 3s View ↗
nx run-many -t build ✅ Succeeded 5s View ↗
nx run-many -t test --parallel=3 --ci --maxWork... ✅ Succeeded 1m 37s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-19 15:28:18 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatusKnizka @JamesHenry
0