8000 docs: Translate the home page into Chinese by htmlin · Pull Request #3244 · lerna/lerna · GitHub
[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Translate the home page into Chinese #3244

Closed
wants to merge 1 commit into from
Closed

Conversation

htmlin
Copy link
@htmlin htmlin commented Jul 10, 2022

Description

  • Add i18n support to docs website
  • Translate the home page into Chinese

Motivation and Context

We are Chinese users of Lerna and have been using it for a long time. We are very excited about Nrwl takes stewardship! And we also want to contribute. So we hope to help lerna do a good job of localization. We first completed the translation of the home page, and if possible, we will continue to translate all the remaining documents.

How Has This Been Tested?

change that has absolutely no effect on users

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JamesHenry
Copy link
Member

Thank you so much for working on this @htmlin!

Because it still early days and the docs site is still rapidly evolving we won't yet be able to commit to translations into different languages. There will be some additional configuration needed for docusaurus which will need to plan out in advance or merging translations as well.

We have added this to our internal roadmap and will continue to actively discuss it, but for now I'm afraid I will have to close this one for clarity.

Many thanks again 🙏

@JamesHenry JamesHenry closed this Jul 21, 2022
@htmlin
79C7 Copy link
Author
htmlin commented Jul 22, 2022

@JamesHenry OK, I understand. Look forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0