feat(hooks): useSortableList hook #2884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f897afa to
430b9bb
Compare
430b9bb to
dd34c3d
Compare
acd02
reviewed
Nov 24, 2025
|
|
||
| const [files, setFiles] = useState<File[]>(defaultFiles) | ||
|
|
||
| const { getItemProps } = useSortableList<File, HTMLLIElement>({ |
Collaborator
There was a problem hiding this comment.
can't it be inferred?
const { getItemProps } = useSortableList({
Member
Author
There was a problem hiding this comment.
File could be ✅
The ref type can't be inferred, because here we pass the data to the hook, but it needs to return a ref for an Element and can't infer what type of element it will be (in most cases it will be an li, but it could be something else)
| { id: '10', name: 'Item 10' }, | ||
| ]) | ||
|
|
||
| const { getItemProps } = useSortableList<SimpleItem, HTMLLIElement>({ |
acd02
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
useSortableList. Allows users to make any list sortable.FileUploadto reorder files.Types of changes
Screenshots - Animations
Enregistrement.de.l.ecran.2025-11-24.a.15.58.19.mov