Added hist and named_hist #14
Conversation
|
|
||
|
|
||
| Py_DECREF(ylist); | ||
| Py_DECREF(plot_args); |
There was a problem hiding this comment.
Could you double-check that the reference count of ylist (ylist->ob_refcnt) isn't negative after this? My understanding is that PyTuple_SetItem() does steal the reference and Py_DECREF(plot_args) should be enough dispose it.
There was a problem hiding this comment.
I think you are right, but I will verify before removing Py_DECREF(ylist).
If you are right, all plot methods have to be modified.
There was a problem hiding this comment.
It's looks like it's working correctly like this, no negative values, and seems to be coherent with the doc: https://docs.python.org/2.7/c-api/refcounting.html#c.Py_DECREF
There was a problem hiding this comment.
How did you check it? Trying it myself in gdb gives me the following:
180 Py_DECREF(ylist);
(gdb) p ylist->ob_refcnt
$3 = 1
(gdb) n
181 Py_DECREF(plot_args);
(gdb) p ylist->ob_refcnt
$6 = 0
(gdb) n
182 Py_DECREF(kwargs);
(gdb) p ylist->ob_refcnt
$7 = -1
There was a problem hiding this comment.
I did not checked after Py_DECREF(kwargs) , but why it affect ylist? the 2 objects are not linked right?
There was a problem hiding this comment.
It's an artifact of the gdb display, the line displayed is the next line that will be executed on command n. So the last line represents the state of the program after executing Py_DECREF(plot_args)
matplotlibcpp.h
Outdated
|
|
||
| inline void figure(){ | ||
| PyObject* res = PyObject_CallObject(detail::_interpreter::get().s_python_function_figure, detail::_interpreter::get().s_python_empty_tuple); | ||
| if(!res) throw std::runtime_error("Call to legend() failed."); |
matplotlibcpp.h
Outdated
| PyObject* ylist = PyList_New(y.size()); | ||
|
|
||
| PyObject* kwargs = PyDict_New(); | ||
| PyDict_SetItemString(kwargs, "bins" ,PyFloat_FromDouble(bins)); |
There was a problem hiding this comment.
I think it should be PyLong_FromLong(), running this gives me
/usr/lib/python2.7/dist-packages/numpy/lib/function_base.py:600: VisibleDeprecationWarning: using a non-integer number instead of an integer will result in an error in the future
| Py_DECREF(res); | ||
| return arr; | ||
| } | ||
|
|
There was a problem hiding this comment.
I Added two methods to get x and y limits
|
On Wed, Oct 26, 2016 at 4:38 PM, Benno Evers notifications@github.com
Yes! Thank you! I tried with PyInt_FromLong(..) but was crashing (this Martino Ferrari |
|
On Wed, Oct 26, 2016 at 4:38 PM, Benno Evers notifications@github.com
Yes! Thank you! I tried with PyInt_FromLong(..) but was crashing (this Martino Ferrari |
|
Nice, thanks for your contribution! |
Hi I added hist and named_hist to your code ;)