8000 Drop Python 3.6 support by ono-max · Pull Request #998 · launchableinc/cli · GitHub
[go: up one dir, main page]
Skip to content

Drop Python 3.6 support #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Drop Python 3.6 support #998

wants to merge 2 commits into from

Conversation

ono-max
Copy link
Contributor
@ono-max ono-max commented May 1, 2025 •
edited by coderabbitai bot
Loading

https://github.blog/changelog/2025-01-15-github-actions-ubuntu-20-runner-image-brownout-dates-and-other-breaking-changes/

Summary by CodeRabbit

  • Chores
    • Updated the continuous integration environment to use Ubuntu 22.04 for build jobs.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 1, 2025 •
edited
Loading

"""

Walkthrough

The change updates the GitHub Actions workflow configuration for continuous integration. Specifically, it modifies the operating system version used for the "build" job, switching from "ubuntu-20.04" to "ubuntu-22.04" and removes Python 3.6 from the testing matrix. The Windows runner configuration remains unchanged, as do the other Python versions tested.

Changes

File(s) Change Summary
.github/workflows/python-package.yml Updated the build job's matrix to use "ubuntu-22.04" instead of "ubuntu-20.04" and removed Python 3.6 from the tested Python versions. No other modifications made.

Poem

A hop from twenty to twenty-two,
In Ubuntu fields so fresh and new,
The runners dash, the tests all pass,
On greener grass, they’re fast as glass.
CI bunnies leap with glee—
New workflows set, so bug-free!
🐇✨
"""

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8729ba and fb897af.

📒 Files selected for processing (1)
  • .github/workflows/python-package.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/python-package.yml
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: build (windows-latest, 3.12)
  • GitHub Check: build (windows-latest, 3.11)
  • GitHub Check: build (windows-latest, 3.10)
  • GitHub Check: build (windows-latest, 3.9)
  • GitHub Check: build (windows-latest, 3.8)
  • GitHub Check: build (windows-latest, 3.7)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

ono-max
ono-max commented May 1, 2025
View reviewed changes
.github/workflows/python-package.yml
@@ -35,8 +35,8 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-20.04, windows-latest]
python-version: [3.6, 3.7, 3.8, 3.9, "3.10", "3.11", "3.12"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Version 3.6 was not found in the local cache
  Error: The version '3.6' with architecture 'x64' was not found for Ubuntu 22.04.
  The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

https://github.com/launchableinc/cli/actions/runs/14768537204/job/41464487287

coderabbitai[bot]
coderabbitai bot reviewed May 1, 2025
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 536fc38 and c8729ba.

📒 Files selected for processing (1)
  • .github/workflows/python-package.yml (1 hunks)

@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented May 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ono-max ono-max requested a review from Konboi May 1, 2025 02:41
Konboi
Konboi requested changes May 1, 2025
View reviewed changes
Copy link
Contributor
@Konboi Konboi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you drop Python 3.6, please write a DACI document and get approval like https://cloudbees.atlassian.net/wiki/spaces/PRODUCT/pages/4431017109/DACI+Drop+support+Python3.5

Also, we'll need to update the doc
https://www.launchableinc.com/docs/resources/cli-reference/

@ono-max
Copy link
Contributor Author
ono-max commented May 1, 2025

Thank you, I'm gonna follow that steps.

@ono-max ono-max changed the title Update the Ubuntu version in CI Drop Python 3.6 support May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Konboi Konboi Konboi requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ono-max @Konboi
0