-
Notifications
You must be signed in to change notification settings - Fork 783
[13.x] Refactor migrations #1759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.x] Refactor migrations #1759
Conversation
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
| $table->unsignedBigInteger('user_id')->index(); | ||
| $table->unsignedBigInteger('client_id'); | ||
| $table->char('id', 80)->primary(); | ||
| $table->foreignId('user_id'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why no index here anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the column itself is redundant #1752
There is no breaking change on this PR, just better migrations for new apps. No need to change/modify columns for existing apps.
passport.connectionon migrations (Related to [12.x] Make Passport's database connection configurable #1738)foreignIdinstead ofunsignedBigInteger, makes the purpose of the column more clear.