[5.8] Add support for reportable, renderable, and responsable exceptions #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for using the
report()andrender()methods on exceptions which is in the documentation but not currently implemented in Lumen (as mentioned in #873).This allows the exception handler class to check for an existing
reportorrendermethod on the exception, mostly the same way as in Laravel's core handler (report and render).It also adds support for exceptions that implement the
Responsablecontract.However, I wasn't able to use the
Router::toResponse($request, $response);call and the$containerproperty doesn't exist on Lumen, so this implementation is closer to the older version of Laravel (5.5 I think?).I would assume that this closes #873, however, they were using Lumen 5.7, so not sure.