10000 Add support for UrlRoutable to route() by jenssegers · Pull Request #145 · laravel/lumen-framework · GitHub
[go: up one dir, main page]

Skip to content

Add support for UrlRoutable to route() #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2015
Merged

Add support for UrlRoutable to route() #145

merged 1 commit into from
Jun 16, 2015

Conversation

jenssegers
Copy link
Contributor

I noticed that route() does not support the UrlRoutable interface. This is a first attempt to add it.

@GrahamCampbell
Copy link
Member

5.0 is closed for changes.

@GrahamCampbell
Copy link
Member

Whoops. Missread the name of the repo...

@jenssegers
Copy link
Contributor Author

Should I do the PR on master?

@GrahamCampbell
Copy link
Member

No.

taylorotwell added a commit that referenced this pull request Jun 16, 2015
Add support for UrlRoutable to route()
@taylorotwell taylorotwell merged commit 87d5ae7 into laravel:5.0 Jun 16, 2015
@jenssegers
Copy link
Contributor Author

Cheers! 🍻

@jenssegers jenssegers mentioned this pull request Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0