faker documentaion #4291
Closed
faker documentaion #4291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't like the fact we have to add
```
<script>
window.Laravel = {!! json_encode([
'csrfToken' => csrf_token(),
]) !!};
</script>
```
To have it working, when the docs suggest adding only the meta tag. This will get the token from the meta tag.
Add missing IPv4/IPv6 validation messages
Update CHANGELOG.md
Simplify test suite names
Dynamic changing locale
Note that I left your dang `const` as it is, even though it's stupid. `let` for life. 💃💃💃💃
Simplify mix require
Sass compilers can sometimes be weird if import urls like this aren't quoted. They'll spit out junk like ``` Error: Encountered invalid @import syntax. ``` Anyways, pretty common practice to use quotes for all imports. I mean, seriously, how much more do you want me to write for a dang PR that adds a pair of quotes? I've got work to do, gah.
|
This information is already well documented at the faker repository. https://github.com/fzaninotto/Faker There is absolutely no need for it to be documented in Laravel. That is like asking for Laravel to document every function of the PHP language. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add faker factory based documentation with all possible data types ,combinations,api so that anybody can create datas they want.Laravel db seeding with faker is an awesome feature but lags in doc.