Make sure mutators also are called from pivot constructor #8900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know this is old but seems broken to me. When we set the new attributes on a new pivot they are fresh out of the database and we shouldn't be mutating them on setting. I think the original code was right and seems to fix problems that have come up because of this: Any thoughts? |
|
As you said it's a long time ago, but I think my expectation was that a pivot constructor would behave the same way as a model constructor. I don't really remember where/how I was burned by this, so it's hard to argue a use case right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix makes sure that the Pivot constructor also calls mutators defined on Pivot class by using forceFill instead of setRawAttributes.