8000 [5.0] Allow composer require illuminate/routing without extra illuminate/events by Marwelln · Pull Request #7582 · laravel/framework · GitHub
[go: up one dir, main page]
Skip to content

[5.0] Allow composer require illuminate/routing without extra illuminate/events #7582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[5.0] Allow composer require illuminate/routing without extra illuminate/events #7582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update composer.json 
If we are trying to use `illuminate/routing`, we are required to manually require `illuminate/events` as it's used in the [`__construct`](https://github.com/laravel/framework/blob/5.0/src/Illuminate/Routing/Router.php#L110) method of  `Illuminate\Routing\Router.php`. This change will allow us to only require `illuminate/routing` if we want to use the routing system without the main Laravel framework.
  • Loading branch information
@Marwelln
Marwelln committed Feb 23, 2015
commit 3cd9c5e2f32f54b269f281ad1748f352b4c5784f
1 change: 1 addition & 0 deletions src/Illuminate/Routing/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"php": ">=5.4.0",
"illuminate/container": "5.0.*",
"illuminate/contracts": "5.0.*",
"illuminate/events": "5.0.*",
"illuminate/http": "5.0.*",
"illuminate/pipeline": "5.0.*",
"illuminate/session": "5.0.*",
Expand Down
0