-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Update PHPDocs for IDE support. #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
corrected the namespaces.
Looks like you broke the line endings, though. |
There's no reason to prefix it with the backslash is there? |
Jason, that was discussed in another issue. Basically, it's about IDE support. Taylor essentially said something along the lines of he might change them to this "proper" way while changing other things, but I'm sure he's thankful for somebody doing all this work for him. |
Ah okay then, fair enough! :) |
I'm not done yet. The rest is still coming.
This reverts commit e9c98dc.
Looks good :) |
👍 It is really annoying to not have autocompletion. Somehow makes the complete PHPDocs useless. |
…n-endpoints-tests Subscription endpoints tests
Type hint parameter to match the changes in contract
corrected the namespaces.