[12.x] Resolve the correct queue factory when using laravel octane #58530
Conversation
|
Hi. Can you please explain this change? At first look it does the same thing. |
|
@marius-ciclistu I think it's about it: https://laravel.com/docs/12.x/octane#container-injection |
|
@rodrigopedra FYI. |
It should, or it does? Can you add a test case to show the issue? I don't understand how this change solves the issue, especially when the dispatcher holds the Why does the And how is this related to the If there is an issue with re-instantiating Do you have a public repository where we can easily reproduce this issue? |
|
It does fix the issue. I have no idea how to add a test for this as it only happens when octane is used. @rodrigopedra I don't know exactly why this is the case, you can read more about it in the documentation. |
|
@BertvanHoekelen later on the link you sent, we can read this:
Reference https://laravel.com/docs/12.x/octane#container-injection "...container unexpectedly missing bindings that were added later in the boot cycle" is not the case for the I created the repository below to test the issue and cannot reproduce the issue: https://github.com/rodrigopedra/pr-58530 It works as expected without errors. I tested only using the FrankenPHP driver, but you can try others if needed. Can you review what I might be doing wrong? And guide us on how to reproduce it? |
|
Merging as this is directionally the correct way to be Octane compatible at least. |
This change breaks sending queued notifications when used with Laravel Octane. The first request proceeds as usual, however the on the second request I get
Target [Illuminate\Contracts\Queue\Factory] is not instantiable.. This PR should resolve that issue