8000 [12.x] Fix email rule helper message by erik-perri · Pull Request #57323 · laravel/framework · GitHub
[go: up one dir, main page]
Skip to content

[12.x] Fix email rule helper message #57323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2025
Merged

[12.x] Fix email rule helper message #57323

merged 2 commits into from
Oct 9, 2025
+2 −6

Conversation

erik-perri
Copy link
Contributor

When using the Rule::email helper, if you validate a non-string you end up with the class name as the validation message since no messages get set in the rule. I did see the test was expecting that, but without a mention in the docs of needing Email::class => '...', in your validation file to use the helper I assumed it was unintentional (or there used to be something converting the class string that was lost).

Since the email validator it falls back to will fail on a non-string anyway I removed the check and let it get replaced with the invalid validation message.

% composer create-project laravel/laravel test-app
% cd test-app/
% php artisan tinker
> Validator::make(['email_address' => 'test@example.com'], ['email_address' => \Illuminate\Validation\Rule::email()])->errors()->toArray()
= []

> Validator::make(['email_address' => 'not-an-email'], ['email_address' => \Illuminate\Validation\Rule::email()])->errors()->toArray()
= [
    "email_address" => [
      "The email address field must be a valid email address.",
    ],
  ]

> Validator::make(['email_address' => 123], ['email_address' => \Illuminate\Validation\Rule::email()])->errors()->toArray()
= [
    "email_address" => [
      "Illuminate\Validation\Rules\Email",
    ],
  ]

> Validator::make(['email_address' => ['not-a-string']], ['email_address' => \Illuminate\Validation\Rule::email()])->errors()->toArray()
= [
    "email_address" => [
      "Illuminate\Validation\Rules\Email",
    ],
  ]

@taylorotwell taylorotwell merged commit 95fc3d0 into laravel:12.x Oct 9, 2025
66 checks passed
@erik-perri erik-perri deleted the fix-email-rule-helper branch October 9, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erik-perri @taylorotwell
0