8000 [12.x] Align PHPDoc style in Number::parseFloat with the rest of the class by AhmedAlaa4611 · Pull Request #56206 · laravel/framework · GitHub
[go: up one dir, main page]
Skip to content

[12.x] Align PHPDoc style in Number::parseFloat with the rest of the class #56206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

[12.x] Align PHPDoc style in Number::parseFloat with the rest of the class #56206

merged 1 commit into from
Jul 3, 2025
+2 −2

Conversation

AhmedAlaa4611
Copy link
Contributor
@AhmedAlaa4611 AhmedAlaa4611 commented Jul 3, 2025 •
edited
Loading

Description

The @param PHPDoc comments in parseFloat are inconsistent with the rest of the class, where the parameters are usually listed without inline descriptions. For consistency, it's better to remove those inline comments.

@taylorotwell taylorotwell merged commit a4d1659 into laravel:12.x Jul 3, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmedAlaa4611 @taylorotwell
0