[12.x] Allows using --model and --except via PruneCommand command
#56140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… at same time Fix: #56139
--model and --except via PruneCommand command
shaedrich
reviewed
Jun 26, 2025
Comment on lines
+118
to
+130
| $models = $this->option('model'); | ||
| $except = $this->option('except'); | ||
|
|
||
| if (! empty($models) && ! empty($except)) { | ||
| if ($models && $except) { | ||
| throw new InvalidArgumentException('The --models and --except options cannot be combined.'); | ||
| } | ||
|
|
||
| if ($models) { | ||
| return (new Collection($models)) | ||
| ->filter(static fn (string $model) => class_exists($model)) | ||
| ->values(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Or, you use promptForMissingArgumentsUsing():
protected function promptForMissingArgumentsUsing() {
return [
'model' => fn () => text(
label: 'model',
validate: ['model' => 'prohibited_with:except']
),
'except' => fn () => text(
label: 'model',
validate: ['except' => 'prohibited_with:model']
),
];
}There was a problem hiding this comment.
That can even go one step further:
protected function afterPromptingForMissingArgumentsInputInterface $input, OutputInterface $output): void
{
$input->setOption('model', text(
label: 'model',
default: $this->option('model'),
transform: fn ($models) => (new Collection($models))
->filter(static fn (string $model) => class_exists($model))
->values()
));
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #56139
This will fix unreachable code when using both
--modeland--exceptat the same time onPruneCommand