:clean: remove inadvertent inclusions

laravel · yitzwillroth · Jun 8, 2025 · Jun 8, 2025 · Jun 8, 2025 · Jun 11, 2025
commit 485efd0f176248def96c3bdf18ee39d298197ffe
diff --git a/src/Illuminate/Cache/FileStore.php b/src/Illuminate/Cache/FileStore.php
@@ -312,7 +312,7 @@ protected function getPayload($key)
             }
 
             $expire = substr($contents, 0, 10);
-        } catch (Exception $e) {
+        } catch (Exception) {
             return $this->emptyPayload();
         }
 
@@ -328,7 +328,6 @@ protected function getPayload($key)
         try {
             $data = unserialize(substr($contents, 10));
         } catch (Exception) {
-
             $this->forget($key);
 
             return $this->emptyPayload();

diff --git a/src/Illuminate/Cache/RedisStore.php b/src/Illuminate/Cache/RedisStore.php
@@ -466,6 +466,7 @@ protected function serialize($value)
      * Determine if the given value should be stored as plain value.
      *
      * @param  mixed  $value
+     * @return bool
      */
     protected function shouldBeStoredWithoutSerialization($value): bool
     {

diff --git a/src/Illuminate/Cache/Repository.php b/src/Illuminate/Cache/Repository.php
@@ -106,6 +106,7 @@ public function missing($key)
      *
      * @param  array|string  $key
      * @param  mixed  $default
+     * @return mixed
      */
     public function get($key, $default = null): mixed
     {
@@ -250,6 +251,8 @@ public function put($key, $value, $ttl = null)
 
     /**
      * {@inheritdoc}
+     *
+     * @return bool
      */
     public function set($key, $value, $ttl = null): bool
     {
@@ -259,6 +262,7 @@ public function set($key, $value, $ttl = null): bool
     /**
      * Store multiple items in the cache for a given number of seconds.
      *
+     * @param  array  $values
      * @param  \DateTimeInterface|\DateInterval|int|null  $ttl
      * @return bool
      */
@@ -292,6 +296,7 @@ public function putMany(array $values, $ttl = null)
     /**
      * Store multiple items in the cache indefinitely.
      *
+     * @param  array  $values
      * @return bool
      */
     protected function putManyForever(array $values)
@@ -526,7 +531,7 @@ public function flexible($key, $ttl, $callback, $lock = null)
     public function touch(string $key, \DateTimeInterface|\DateInterval|int|null $ttl = null): bool
     {
         $value = $this->get($key);
-        
+
         if (is_null($value)) {
             return false;
         }
@@ -557,6 +562,8 @@ public function forget($key)
 
     /**
      * {@inheritdoc}
+     *
+     * @return bool
      */
     public function delete($key): bool
     {
@@ -565,6 +572,8 @@ public function delete($key): bool
 
     /**
      * {@inheritdoc}
+     *
+     * @return bool
      */
     public function deleteMultiple($keys): bool
     {
@@ -581,6 +590,8 @@ public function deleteMultiple($keys): bool
 
     /**
      * {@inheritdoc}
+     *
+     * @return bool
      */
     public function clear(): bool
     {
@@ -742,6 +753,7 @@ public function getEventDispatcher()
     /**
      * Set the event dispatcher instance.
      *
+     * @param  \Illuminate\Contracts\Events\Dispatcher  $events
      * @return void
      */
     public function setEventDispatcher(Dispatcher $events)
@@ -753,6 +765,7 @@ public function setEventDispatcher(Dispatcher $events)
      * Determine if a cached value exists.
      *
      * @param  string  $key
+     * @return bool
      */
     public function offsetExists($key): bool
     {
@@ -763,6 +776,7 @@ public function offsetExists($key): bool
      * Retrieve an item from the cache by key.
      *
      * @param  string  $key
+     * @return mixed
      */
     public function offsetGet($key): mixed
     {
@@ -774,6 +788,7 @@ public function offsetGet($key): mixed
      *
      * @param  string  $key
      * @param  mixed  $value
+     * @return void
      */
     public function offsetSet($key, $value): void
     {
@@ -784,6 +799,7 @@ public function offsetSet($key, $value): void
      * Remove an item from the cache.
      *
      * @param  string  $key
+     * @return void
      */
     public function offsetUnset($key): void
     {

diff --git a/tests/Cache/CacheApcStoreTest.php b/tests/Cache/CacheApcStoreTest.php
@@ -146,6 +146,4 @@ public function testFlushesCached()
         $result = $store->flush();
         $this->assertTrue($result);
     }
-
-
 }
diff --git a/tests/Cache/CacheRedisStoreTest.php b/tests/Cache/CacheRedisStoreTest.php
@@ -136,14 +136,10 @@ public function testTouchMethodProperlyCallsRedis(): void
 
     public function testForgetMethodProperlyCallsRedis()
     {
-        $key = 'key';
-
         $redis = $this->getRedis();
-
         $redis->getRedis()->shouldReceive('connection')->once()->with('default')->andReturn($redis->getRedis());
-        $redis->getRedis()->shouldReceive('del')->once()->with("prefix:$key");
-
-        $redis->forget($key);
+        $redis->getRedis()->shouldReceive('del')->once()->with('prefix:foo');
+        $redis->forget('foo');
     }
 
     public function testFlushesCached()
-Original file line number
+Diff line change
@@ Expand Up / @@ -146,6 +146,4 @@ public function testFlushesCached() @@
             $result = $store->flush();
             $this->assertTrue($result);
         }
     }