skip appending page=1 in pagination URLs #55772
Draft
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(pagination): omit ?page=1 and prevent dangling separators Skip adding the `page` query parameter when the requested page equals 1, returning the canonical base path instead. When no extra query parameters are present, the function now suppresses the `?` / `&` separator entirely. This prevents URLs such as `/users?` or `/users&` and avoids duplicate‑content issues for the first page. Behaviour for pages >1 and for existing custom query strings is unchanged.
|
Mark as draft since test are failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(pagination): omit ?page=1 and prevent dangling separators
Skip adding the
pagequery parameter when the requested page equals 1, returning the canonical base path instead.When no extra query parameters are present, the function now suppresses the
?/&separator entirely. This prevents URLs such as/users?or/users&and avoids duplicate‑content issues for the first page.Behaviour for pages >1 and for existing custom query strings is unchanged.