[12.x] Types: InteractsWithPivotTable::sync #55762

liamduckett · 2025-05-17T17:13:45Z

InteractsWithPivotTable::sync currently works when passing a single ID to it:

$category->food()->sync($item->id);

// works due to:
protected function parseIds($value)
{
    if ($value instanceof Model) {
        // ...
    }

    if ($value instanceof EloquentCollection) {
        // ...
    }

    if ($value instanceof BaseCollection || is_array($value)) {
        // ...
    }

    return (array) $value;
}

However, static analysis doesn't know about this, due to:

  /**
   * Sync the intermediate tables with a list of IDs or collection of models.
   *
   * @param  \Illuminate\Support\Collection|\Illuminate\Database\Eloquent\Model|array  $ids
   * @param  bool  $detaching
   * @return array{attached: array, detached: array, updated: array}
   */
  public function sync($ids, $detaching = true)

My usecase only uses int $ids but I thought it best to add string whilst I was on (for uuids).

I also applied this change to methods that call the sync method.

…sync

allow passing a single string or integer to InteractsWithPivotTable::…

21f94ad

…sync

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.x] Types: InteractsWithPivotTable::sync #55762

[12.x] Types: InteractsWithPivotTable::sync #55762

[12.x] Types: InteractsWithPivotTable::sync #55762

Are you sure you want to change the base?

[12.x] Types: InteractsWithPivotTable::sync #55762

Conversation