-
Notifications
You must be signed in to change notification settings - Fork 11.4k
[12.x] Allow naming queued closures #55634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
taylorotwell
merged 3 commits into
laravel:12.x
from
willrowe:feature/name-queued-closures
May 5, 2025
Merged
[12.x] Allow naming queued closures #55634
taylorotwell
merged 3 commits into
laravel:12.x
from
willrowe:feature/name-queued-closures
May 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
403714d to
5da65f2
Compare
miki131
reviewed
May 2, 2025
Comment on lines
116
to
118
| if (! is_null($this->name)) { | ||
| $prefix = "{$this->name} - "; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$prefix = is_null($this->name) ? '' : "{$this->name} - ";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a queued closure to be given a name in order to be more easily identified. The name is prefixed to the display name so that it still denotes that it is a closure and where it is located.