[12.x] Set class-string generics on Enum rule
#55588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear god, I hope this gets merged. So that we're not eternally fighting the demons inside static analytics |
|
Wondering if this should be done like this 🤔 /*
* @template T of \UnitEnum
*/
class Enum implements Rule, ValidatorAwareRule
{
use Conditionable;
/**
* The type of the enum.
*
* @var class-string<T>
*/
protected $type;
// …
/**
* Create a new rule instance.
*
* @param class-string<T> $type
*/
public function __construct($type)
{
$this->type = $type;
}or even via constructor property promotion class Enum implements Rule, ValidatorAwareRule
{
use Conditionable;
// …
/**
* Create a new rule instance.
*
* @template T of \UnitEnum
* @param class-string<T> $type
*/
public function __construct(protected $type)
{
}PS: You'd have good chances of winning "best PR description of the month" or so if there was such a thing 😂👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds class-string generics to the
Enumrule. Will aid in static analysis.Dear Taylor,
Lord knows you don't want to see another typehint PR.
But me, and countless others, are slaves to PHPStan. It's not enough to have PHPStan as a part of the development process and let it guide me. No... it rules my life. Every commit I make is at the mercy of the PHPStan pipeline. If I don't keep PHPStan on level 7 satisfied, I fear my children will not eat. You can't fault a man for wanting to sustain his livelihood.
And sickest of all, perhaps, is that I'm the one who added PHPStan to our pipelines. But I digress.
I hope that you can sympathize with my plight and consider this humble PR. 🙏
Kind regards,
Luke