Update compiled views only if they actually changed #55450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
663fa79 to
fe0de84
Compare
When running in a read-only filesystem container with views pre-cached at build time, Laravel checks if the cached view's timestamp is older than the source's to decide when to recompile. This is fine as long as we do not make OCI image builds reproducible. If we do however, the timestamps match (because timestamps of all files are set to 01.01.1970), so Laravel recompiles the view, tries to write to a read-only filesystem and the container crashes. This patch computes SHA256 hashes over existing and newly compiled file contents, compares those and writes only if the file actually changes.
fe0de84 to
5f39764
Compare
|
Now with proper Unit tests. \o/ |
|
Never mind, figure out already. It only checks the hash when it needs to compile. In other words, after checking for the timestamp. |
osbre
reviewed
Apr 17, 2025
| return; | ||
| } | ||
|
|
||
| $contentHash = hash('sha256', $contents); |
There was a problem hiding this comment.
There was a problem hiding this comment.
xxh128 seems like a better choice. I will change it.
|
Yeah, could use xxh128 since we're using that in other areas. |
|
Sorry, I was on vacation. Actually, I realized that this effectively defeats the purpose of view caching as every view is compiled every time it is accessed. I noticed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in a read-only filesystem container with views pre-cached at build time, Laravel checks if the cached view's timestamp is older than the source's to decide when to recompile. This is fine as long as we do not make OCI image builds reproducible.
If we do however, the timestamps match (because timestamps of all files are set to 01.01.1970), so Laravel recompiles the view, tries to write to a read-only filesystem and the container crashes.
This patch computes SHA256 hashes over existing and newly compiled file contents, compares those and writes only if the file actually changes.