[11.x] Fix missing `return $this` for `assertOnlyJsonValidationErrors` #55099

LeTamanoir · 2025-03-20T16:15:54Z

The assertOnlyJsonValidationErrors does not return $this even though it is type hinted to return $this.

framework/src/Illuminate/Testing/TestResponse.php

Lines 979 to 997 in 32bbb68

    
               /** 
        
                * Assert that the response has the given JSON validation errors but does not have any other JSON validation errors. 
        
                * 
        
                * @param  string|array  $errors 
        
                * @param  string  $responseKey 
        
                * @return $this 
        
                */ 
        
               public function assertOnlyJsonValidationErrors($errors, $responseKey = 'errors') 
        
               { 
        
                   $this->assertJsonValidationErrors($errors, $responseKey); 
        
                   $jsonErrors = Arr::get($this->json(), $responseKey) ?? []; 
        
                   $expectedErrorKeys = collect($errors)->map(fn ($value, $key) => is_int($key) ? $value : $key)->all(); 
        
                   $unexpectedErrorKeys = Arr::except($jsonErrors, $expectedErrorKeys); 
        
                   PHPUnit::withResponse($this)->assertTrue(count($unexpectedErrorKeys) === 0, 'Response has unexpected validation errors: '.collect($unexpectedErrorKeys)->keys()->map(fn ($key) => "'{$key}'")->join(', ')); 
        
               }

fix missing return

24477bd

taylorotwell merged commit b8a8f83 into laravel:11.x Mar 22, 2025
46 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.x] Fix missing `return $this` for `assertOnlyJsonValidationErrors` #55099

[11.x] Fix missing `return $this` for `assertOnlyJsonValidationErrors` #55099

	/**
	* Assert that the response has the given JSON validation errors but does not have any other JSON validation errors.
	*
	* @param string\|array $errors
	* @param string $responseKey
	* @return $this
	*/
	public function assertOnlyJsonValidationErrors($errors, $responseKey = 'errors')
	{
	$this->assertJsonValidationErrors($errors, $responseKey);

	$jsonErrors = Arr::get($this->json(), $responseKey) ?? [];

	$expectedErrorKeys = collect($errors)->map(fn ($value, $key) => is_int($key) ? $value : $key)->all();

	$unexpectedErrorKeys = Arr::except($jsonErrors, $expectedErrorKeys);

	PHPUnit::withResponse($this)->assertTrue(count($unexpectedErrorKeys) === 0, 'Response has unexpected validation errors: '.collect($unexpectedErrorKeys)->keys()->map(fn ($key) => "'{$key}'")->join(', '));
	}

[11.x] Fix missing return $this for assertOnlyJsonValidationErrors #55099

[11.x] Fix missing return $this for assertOnlyJsonValidationErrors #55099

Conversation

[11.x] Fix missing `return $this` for `assertOnlyJsonValidationErrors` #55099

[11.x] Fix missing `return $this` for `assertOnlyJsonValidationErrors` #55099