Fix: Inconsistent accessor attribute name conversion #54578
Conversation
| public function testSnakeCaseMutateAttribute() | ||
| { | ||
| $instance = new HasAttributesWithSnakeCaseConsistentCheck(); | ||
| $this->assertEquals('foo2Bar', $instance->getAttribute('foo2Bar')); |
There was a problem hiding this comment.
I'm not sure these tests are correct, as getAttribute was working properly before the change you've made. You can test it in Tinker ie before & after.
I believe it should be testing ->append('foo_2_bar')->toArray() etc, ie the same scenario as the issue, as it's altered mutateAttributeForArray which is called by attributesToArray
(ie the test should be testing the scenario of the issue to verify it's fixed :) )
There was a problem hiding this comment.
Yeah sure I will make a test for those too
There was a problem hiding this comment.
@jackbayliss , tested with multiple scenarios including toArray() , its is working fine as excpected
|
I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework. Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc. Thanks! |
This goes with issue #54570
Inconsistent accessor attribute name conversion for mutateAttributeMarkedAttribute