[11.x] feat: add better closure typing in QueriesRelationships #54452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one has conflicts. |
1db9558 to
31061af
Compare
|
@taylorotwell, I've fixed the conflicts, as well as some static analysis failures that were introduced onto |
|
@calebdw this has merge conflicts. |
b4471ff to
6317d81
Compare
|
Should be fixed now |
6317d81 to
6f5602b
Compare
|
Thank you sir! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This adds better closure types to the methods in
QueriesRelationships:Closes calebdw/larastan#25
Thanks!